From 22d33ebf9979443dcbebaf9c015a61cff556e932 Mon Sep 17 00:00:00 2001 From: David Chisnall Date: Mon, 29 Apr 2019 15:00:25 +0100 Subject: [PATCH] Add another checker. Use nullptr where appropriate. --- .clang-tidy | 2 +- src/override/malloc.cc | 2 +- src/pal/pal_freebsd.h | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/.clang-tidy b/.clang-tidy index 3c5dcf0..021a3eb 100644 --- a/.clang-tidy +++ b/.clang-tidy @@ -1 +1 @@ -Checks: '-*,clang-diagnostic-*,google-readability-casting,readability-else-after-return' +Checks: '-*,clang-diagnostic-*,google-readability-casting,readability-else-after-return,performance-unnecessary-copy-initialization,bugprone-use-after-move,modernize-use-nullptr' diff --git a/src/override/malloc.cc b/src/override/malloc.cc index ce4973e..db1b1bb 100644 --- a/src/override/malloc.cc +++ b/src/override/malloc.cc @@ -254,7 +254,7 @@ extern "C" if (overflow) { errno = ENOMEM; - return 0; + return nullptr; } // Include size 0 in the first sizeclass. sz = ((sz - 1) >> (bits::BITS - 1)) + sz; diff --git a/src/pal/pal_freebsd.h b/src/pal/pal_freebsd.h index 1c8b04e..f75347d 100644 --- a/src/pal/pal_freebsd.h +++ b/src/pal/pal_freebsd.h @@ -78,7 +78,7 @@ namespace snmalloc size_t log2align = bits::next_pow2_bits(align); void* p = mmap( - NULL, + nullptr, request, PROT_READ | PROT_WRITE, MAP_PRIVATE | MAP_ANONYMOUS | MAP_ALIGNED(log2align),