Code review feedback.
This commit is contained in:
@@ -63,11 +63,10 @@ namespace snmalloc
|
||||
template<bool committed>
|
||||
void* reserve(size_t size, size_t align)
|
||||
{
|
||||
size_t request = size;
|
||||
vm_offset_t addr;
|
||||
if (vmem_xalloc(
|
||||
kernel_arena,
|
||||
request,
|
||||
size,
|
||||
align,
|
||||
0,
|
||||
0,
|
||||
@@ -81,10 +80,10 @@ namespace snmalloc
|
||||
if (committed)
|
||||
{
|
||||
if (
|
||||
kmem_back(kernel_object, addr, request, M_ZERO | M_WAITOK) !=
|
||||
kmem_back(kernel_object, addr, size, M_ZERO | M_WAITOK) !=
|
||||
KERN_SUCCESS)
|
||||
{
|
||||
vmem_xfree(kernel_arena, addr, request);
|
||||
vmem_xfree(kernel_arena, addr, size);
|
||||
return nullptr;
|
||||
}
|
||||
}
|
||||
|
||||
@@ -54,7 +54,7 @@ namespace snmalloc
|
||||
void notify_not_using(void* p, size_t size) noexcept
|
||||
{
|
||||
assert(is_aligned_block<OS_PAGE_SIZE>(p, size));
|
||||
#ifndef NDEBUG
|
||||
#ifdef USE_POSIX_COMMIT_CHECKS
|
||||
mprotect(p, size, PROT_NONE);
|
||||
#else
|
||||
UNUSED(p);
|
||||
@@ -77,7 +77,7 @@ namespace snmalloc
|
||||
if constexpr (zero_mem == YesZero)
|
||||
static_cast<OS*>(this)->template zero<true>(p, size);
|
||||
|
||||
#ifndef NDEBUG
|
||||
#ifdef USE_POSIX_COMMIT_CHECKS
|
||||
mprotect(p, size, PROT_READ | PROT_WRITE);
|
||||
#else
|
||||
UNUSED(p);
|
||||
|
||||
Reference in New Issue
Block a user