From 9dc689762c649a9f0436e52f48eb3e88d47260ca Mon Sep 17 00:00:00 2001 From: Matthew Parkinson Date: Wed, 4 Mar 2020 17:44:54 +0000 Subject: [PATCH] Apply suggestions from code review --- src/ds/defines.h | 3 ++- src/pal/pal_consts.h | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/src/ds/defines.h b/src/ds/defines.h index 0237657..2638958 100644 --- a/src/ds/defines.h +++ b/src/ds/defines.h @@ -32,11 +32,12 @@ namespace snmalloc { + // Forwards reference so that the platform can define how to handle errors. void error(const char* const str); } // namespace snmalloc #ifdef NDEBUG -# define SNMALLOC_ASSERT(expr) ((void 0)) +# define SNMALLOC_ASSERT(expr) { } #else # define SNMALLOC_ASSERT(expr) \ { \ diff --git a/src/pal/pal_consts.h b/src/pal/pal_consts.h index 3d2bb5f..a86feb5 100644 --- a/src/pal/pal_consts.h +++ b/src/pal/pal_consts.h @@ -116,4 +116,4 @@ namespace snmalloc } } }; -} // namespace snmalloc \ No newline at end of file +} // namespace snmalloc