From d06e53973283dd263765ddc6dbfb42a9a5f5295b Mon Sep 17 00:00:00 2001 From: David Chisnall Date: Mon, 29 Apr 2019 15:33:31 +0100 Subject: [PATCH] Add more checks. Add missing parentheses in UNUSED (shouldn't matter, but keeps a checker that may catch real bugs elsewhere happy). --- .clang-tidy | 3 ++- src/ds/bits.h | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/.clang-tidy b/.clang-tidy index c96e19c..fd1ddf2 100644 --- a/.clang-tidy +++ b/.clang-tidy @@ -1,7 +1,8 @@ -Checks: '-*,clang-diagnostic-*,google-readability-casting,readability-else-after-return,performance-unnecessary-copy-initialization,bugprone-use-after-move,modernize-use-nullptr,modernize-redundant-void-arg,modernize-return-braced-init-list,modernize-use-default-member-init,modernize-use-equals-default,modernize-use-equals-delete,modernize-use-nodiscard,modernize-use-override,cppcoreguidelines-avoid-goto,misc-unconventional-assign-operator' +Checks: '-*,clang-diagnostic-*,google-readability-casting,readability-else-after-return,performance-unnecessary-copy-initialization,bugprone-use-after-move,modernize-use-nullptr,modernize-redundant-void-arg,modernize-return-braced-init-list,modernize-use-default-member-init,modernize-use-equals-default,modernize-use-equals-delete,modernize-use-nodiscard,modernize-use-override,cppcoreguidelines-avoid-goto,misc-unconventional-assign-operator,cppcoreguidelines-narrowing-conversions,bugprone-assert-side-effect,bugprone-bool-pointer-implicit-conversion,bugprone-copy-constructor-init,bugprone-forward-declaration-namespace,bugprone-forwarding-reference-overload,bugprone-macro-parentheses' # It would be nice to enable: # - readability-magic-numbers # - modernize-avoid-c-arrays +# - cppcoreguidelines-pro-bounds-array-to-pointer-decay (assert breaks it). CheckOptions: - key: modernize-use-default-member-init.UseAssignment value: '1' diff --git a/src/ds/bits.h b/src/ds/bits.h index bcf7cca..29e3863 100644 --- a/src/ds/bits.h +++ b/src/ds/bits.h @@ -40,7 +40,7 @@ # define __has_builtin(x) 0 #endif -#define UNUSED(x) ((void)x) +#define UNUSED(x) ((void)(x)) // #define USE_LZCNT