Peernet-Archive/core
1
0
Fork 0
mirror of https://github.com/PeernetOfficial/core.git synced 2026-07-22 04:37:50 +01:00
Code Issues Packages Projects Releases Wiki Activity

New function record.IsBadQuality to make sure bad peers returned in the Response message are not considered.

Browse Source 
Improved remote peer NAT detection. Placeholder for sending the Traverse message.
Fix in handling incoming FIND_PEER request. Do not return self as closest node.
Do not share peers for which the internal port is not known.
This commit is contained in:
Kleissner
2021-05-09 00:49:34 +02:00
parent f70875a345
commit f084edc316
4 changed files with 81 additions and 30 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
Bootstrap.go
View File

@@ -226,6 +226,10 @@ func (peer *PeerInfo) cmdResponseBootstrapFindSelf(msg *MessageResponse, closest
}
for _, closePeer := range closest {
if closePeer.IsBadQuality() {
continue
}
// Use the self-reported external port if available.
port := closePeer.Port
if closePeer.PortReportedExternal > 0 {
@@ -239,9 +243,10 @@ func (peer *PeerInfo) cmdResponseBootstrapFindSelf(msg *MessageResponse, closest
}
// If NAT is detected and the port is not forwarded, send a Traverse message.
// NAT detection is the same algorithm as peer.IsBehindNAT.
// NAT detection is the same algorithm as connection.IsBehindNAT.
if closePeer.PortReportedExternal == 0 && closePeer.Port != closePeer.PortReportedInternal {
// TODO send traverse message
//fmt.Printf("FIND_SELF Traverse message needed for target %s target port %d internal %d\n", closePeer.IP.String(), closePeer.Port, closePeer.PortReportedInternal)
}
}
@@ -252,3 +257,20 @@ func ShouldSendFindSelf() bool {
// TODO
return true
}
// IsBadQuality checks if the returned peer record is bad quality and should be discarded
func (record *PeerRecord) IsBadQuality() bool {
// Internal port must be provided. Otherwise the external port is likely not provided either, and checking the NAT and port forwarded status is not possible.
if record.PortReportedInternal == 0 {
//fmt.Printf("IsBadQuality port internal not available for target %s port %d, peer %s\n", record.IP.String(), record.Port, hex.EncodeToString(record.PublicKey.SerializeCompressed()))
return true
}
// Must not be self. There is no point that a remote peer would return self
if record.PublicKey.IsEqual(peerPublicKey) {
//fmt.Printf("IsBadQuality received self peer\n")
return true
}
return false
}