don't allow allocations larger than PTRDIFF_MAX, issue #121

2019-08-19 19:29:27 -07:00
parent 74299646bb
commit 2066e2797d
1 changed files with 1 additions and 1 deletions
--- a/src/page.c
+++ b/src/page.c
@@ -741,7 +741,7 @@ void* _mi_malloc_generic(mi_heap_t* heap, size_t size) mi_attr_noexcept
  // huge allocation?
  mi_page_t* page;
  if (mi_unlikely(size > MI_LARGE_OBJ_SIZE_MAX)) {
-    if (mi_unlikely(size >= (SIZE_MAX - MI_MAX_ALIGN_SIZE))) {
+    if (mi_unlikely(size > PTRDIFF_MAX)) {  // we don't allocate more than PTRDIFF_MAX (see <https://sourceware.org/ml/libc-announce/2019/msg00001.html>)
      page = NULL;
    }
    else {