Cheri-research/snmalloc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

use ::write and ::fsync in error path (#443)

Browse Source 
* use ::write and ::fsync in error path

Signed-off-by: SchrodingerZhu <i@zhuyi.fan>

* mark return value unused

Signed-off-by: SchrodingerZhu <i@zhuyi.fan>

* adjust fsync positions

Signed-off-by: SchrodingerZhu <i@zhuyi.fan>
This commit is contained in:
Schrodinger ZHU Yifan
2021-12-15 22:01:34 +08:00
committed by GitHub
parent d0df2d028a
commit 37d2ac42af
1 changed files with 10 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
src/pal/pal_posix.h
View File

@@ -151,10 +151,9 @@ namespace snmalloc
constexpr int SIZE = 1024;
void* buffer[SIZE];
auto nptrs = backtrace(buffer, SIZE);
fflush(stdout);
backtrace_symbols_fd(buffer, nptrs, STDOUT_FILENO);
puts("");
fflush(stdout);
UNUSED(write(STDOUT_FILENO, "\n", 1));
UNUSED(fsync(STDOUT_FILENO));
#endif
}
@@ -163,7 +162,14 @@ namespace snmalloc
*/
[[noreturn]] static void error(const char* const str) noexcept
{
puts(str);
/// by this part, the allocator is failed; so we cannot assume
/// subsequent allocation will work.
/// @attention: since the program is failing, we do not guarantee that
/// previous bytes in stdout will be flushed
UNUSED(write(STDOUT_FILENO, "\n", 1));
UNUSED(write(STDOUT_FILENO, str, strlen(str)));
UNUSED(write(STDOUT_FILENO, "\n", 1));
UNUSED(fsync(STDOUT_FILENO));
print_stack_trace();
abort();
}