Remove interface linking for PRIVATE linkage (#799)
Some checks failed
snmalloc Benchmarking CI / benchmark (push) Has been cancelled
snmalloc CI / Ubuntu - ubuntu-22.04 Debug (push) Has been cancelled
snmalloc CI / Ubuntu - ubuntu-24.04 Debug (push) Has been cancelled
snmalloc CI / Ubuntu - ubuntu-24.04-arm Debug (push) Has been cancelled
snmalloc CI / Ubuntu - ubuntu-22.04 Debug C++17 (push) Has been cancelled
snmalloc CI / Ubuntu - ubuntu-24.04 Debug with pthread destructors (push) Has been cancelled
snmalloc CI / Ubuntu - ubuntu-22.04 Release (push) Has been cancelled
snmalloc CI / Ubuntu - ubuntu-24.04 Release (push) Has been cancelled
snmalloc CI / Ubuntu - ubuntu-24.04-arm Release (push) Has been cancelled
snmalloc CI / Ubuntu - ubuntu-24.04 Release individual mitigations (push) Has been cancelled
snmalloc CI / Ubuntu - ubuntu-24.04 Release libstdc++ (Build only) (push) Has been cancelled
snmalloc CI / Ubuntu - ubuntu-22.04 Release clang + libstdc++ (Build only) (push) Has been cancelled
snmalloc CI / Ubuntu - ubuntu-22.04 Release Traced Build (push) Has been cancelled
snmalloc CI / Bazel - macos-13 Debug (push) Has been cancelled
snmalloc CI / Bazel - macos-14 Debug (push) Has been cancelled
snmalloc CI / Bazel - macos-15 Debug (push) Has been cancelled
snmalloc CI / Bazel - ubuntu-22.04 Debug (push) Has been cancelled
snmalloc CI / Bazel - ubuntu-24.04 Debug (push) Has been cancelled
snmalloc CI / Bazel - macos-13 Release (push) Has been cancelled
snmalloc CI / Bazel - macos-14 Release (push) Has been cancelled
snmalloc CI / Bazel - macos-15 Release (push) Has been cancelled
snmalloc CI / Bazel - ubuntu-22.04 Release (push) Has been cancelled
snmalloc CI / Bazel - ubuntu-24.04 Release (push) Has been cancelled
snmalloc CI / Mac OS macos-13 Debug (push) Has been cancelled
snmalloc CI / Mac OS macos-14 Debug (push) Has been cancelled
snmalloc CI / Mac OS macos-15 Debug (push) Has been cancelled
snmalloc CI / Mac OS macos-13 Debug -DSNMALLOC_USE_CXX17=ON (push) Has been cancelled
snmalloc CI / Mac OS macos-14 Debug -DSNMALLOC_USE_CXX17=ON (push) Has been cancelled
snmalloc CI / Mac OS macos-15 Debug -DSNMALLOC_USE_CXX17=ON (push) Has been cancelled
snmalloc CI / Mac OS macos-13 Release (push) Has been cancelled
snmalloc CI / Mac OS macos-14 Release (push) Has been cancelled
snmalloc CI / Mac OS macos-15 Release (push) Has been cancelled
snmalloc CI / Mac OS macos-13 Release -DSNMALLOC_USE_CXX17=ON (push) Has been cancelled
snmalloc CI / Mac OS macos-14 Release -DSNMALLOC_USE_CXX17=ON (push) Has been cancelled
snmalloc CI / Mac OS macos-15 Release -DSNMALLOC_USE_CXX17=ON (push) Has been cancelled
snmalloc CI / FreeBSD-13.2 Debug (push) Has been cancelled
snmalloc CI / FreeBSD-13.2 Release (push) Has been cancelled
snmalloc CI / NetBSD-9.2 Release (push) Has been cancelled
snmalloc CI / Sanitizer - ubuntu-22.04 Release libc++ (TSan + UBSan) (push) Has been cancelled
snmalloc CI / Sanitizer - ubuntu-24.04 Release libc++ (TSan + UBSan) (push) Has been cancelled
snmalloc CI / Crossbuild - Debug cross-build for riscv64-linux-gnu (push) Has been cancelled
snmalloc CI / Crossbuild - Release cross-build for riscv64-linux-gnu (push) Has been cancelled
snmalloc CI / Crossbuild - Debug cross-build for aarch64-linux-gnu (push) Has been cancelled
snmalloc CI / Crossbuild - Release cross-build for aarch64-linux-gnu (push) Has been cancelled
snmalloc CI / Crossbuild - Debug cross-build for arm-linux-gnueabihf (push) Has been cancelled
snmalloc CI / Crossbuild - Release cross-build for arm-linux-gnueabihf (push) Has been cancelled
snmalloc CI / Windows - windows-2022 ARM64 Debug (push) Has been cancelled
snmalloc CI / Windows - windows-2022 ARM64 Release (push) Has been cancelled
snmalloc CI / Windows - windows-2022 ARM64EC Debug (push) Has been cancelled
snmalloc CI / Windows - windows-2022 ARM64EC Release (push) Has been cancelled
snmalloc CI / Windows - windows-2022 Win32 Debug (push) Has been cancelled
snmalloc CI / Windows - windows-2022 Win32 Debug -T ClangCL (push) Has been cancelled
snmalloc CI / Windows - windows-2025 Win32 Debug (push) Has been cancelled
snmalloc CI / Windows - windows-2025 Win32 Debug -T ClangCL (push) Has been cancelled
snmalloc CI / Windows - windows-2022 Win32 Release (push) Has been cancelled
snmalloc CI / Windows - windows-2022 Win32 Release -T ClangCL (push) Has been cancelled
snmalloc CI / Windows - windows-2025 Win32 Release (push) Has been cancelled
snmalloc CI / Windows - windows-2025 Win32 Release -T ClangCL (push) Has been cancelled
snmalloc CI / Windows - windows-2022 x64 Debug (push) Has been cancelled
snmalloc CI / Windows - windows-2022 x64 Debug -T ClangCL (push) Has been cancelled
snmalloc CI / Windows - windows-2025 x64 Debug (push) Has been cancelled
snmalloc CI / Windows - windows-2025 x64 Debug -T ClangCL (push) Has been cancelled
snmalloc CI / Windows - windows-2022 x64 Release (push) Has been cancelled
snmalloc CI / Windows - windows-2022 x64 Release -T ClangCL (push) Has been cancelled
snmalloc CI / Windows - windows-2025 x64 Release (push) Has been cancelled
snmalloc CI / Windows - windows-2025 x64 Release -T ClangCL (push) Has been cancelled
snmalloc CI / Windows - windows-2022 x64 Release Windows 8 compatible (push) Has been cancelled
snmalloc CI / Format check (push) Has been cancelled
snmalloc CI / Fuzzing (push) Has been cancelled
snmalloc CI / Self Vendored STL - macos-latest clang++ (push) Has been cancelled
snmalloc CI / Self Vendored STL - ubuntu-24.04 clang++-18 (push) Has been cancelled
snmalloc CI / Self Vendored STL - windows-2022 clang-cl (push) Has been cancelled
snmalloc CI / Self Vendored STL - ubuntu-24.04 g++-14 (push) Has been cancelled
snmalloc CI / gwp-asan (ubuntu-24.04, Debug) (push) Has been cancelled
snmalloc CI / gwp-asan (ubuntu-24.04, RelWithDebInfo) (push) Has been cancelled
snmalloc CI / gwp-asan (ubuntu-24.04-arm, Debug) (push) Has been cancelled
snmalloc CI / gwp-asan (ubuntu-24.04-arm, RelWithDebInfo) (push) Has been cancelled
snmalloc CI / all-checks (push) Has been cancelled
snmalloc CI for Morello / morello Debug Hybrid (push) Has been cancelled
snmalloc CI for Morello / morello Debug Purecap (push) Has been cancelled
snmalloc CI for Morello / morello Release Hybrid (push) Has been cancelled
snmalloc CI for Morello / morello Release Purecap (push) Has been cancelled
Some checks failed
snmalloc Benchmarking CI / benchmark (push) Has been cancelled
snmalloc CI / Ubuntu - ubuntu-22.04 Debug (push) Has been cancelled
snmalloc CI / Ubuntu - ubuntu-24.04 Debug (push) Has been cancelled
snmalloc CI / Ubuntu - ubuntu-24.04-arm Debug (push) Has been cancelled
snmalloc CI / Ubuntu - ubuntu-22.04 Debug C++17 (push) Has been cancelled
snmalloc CI / Ubuntu - ubuntu-24.04 Debug with pthread destructors (push) Has been cancelled
snmalloc CI / Ubuntu - ubuntu-22.04 Release (push) Has been cancelled
snmalloc CI / Ubuntu - ubuntu-24.04 Release (push) Has been cancelled
snmalloc CI / Ubuntu - ubuntu-24.04-arm Release (push) Has been cancelled
snmalloc CI / Ubuntu - ubuntu-24.04 Release individual mitigations (push) Has been cancelled
snmalloc CI / Ubuntu - ubuntu-24.04 Release libstdc++ (Build only) (push) Has been cancelled
snmalloc CI / Ubuntu - ubuntu-22.04 Release clang + libstdc++ (Build only) (push) Has been cancelled
snmalloc CI / Ubuntu - ubuntu-22.04 Release Traced Build (push) Has been cancelled
snmalloc CI / Bazel - macos-13 Debug (push) Has been cancelled
snmalloc CI / Bazel - macos-14 Debug (push) Has been cancelled
snmalloc CI / Bazel - macos-15 Debug (push) Has been cancelled
snmalloc CI / Bazel - ubuntu-22.04 Debug (push) Has been cancelled
snmalloc CI / Bazel - ubuntu-24.04 Debug (push) Has been cancelled
snmalloc CI / Bazel - macos-13 Release (push) Has been cancelled
snmalloc CI / Bazel - macos-14 Release (push) Has been cancelled
snmalloc CI / Bazel - macos-15 Release (push) Has been cancelled
snmalloc CI / Bazel - ubuntu-22.04 Release (push) Has been cancelled
snmalloc CI / Bazel - ubuntu-24.04 Release (push) Has been cancelled
snmalloc CI / Mac OS macos-13 Debug (push) Has been cancelled
snmalloc CI / Mac OS macos-14 Debug (push) Has been cancelled
snmalloc CI / Mac OS macos-15 Debug (push) Has been cancelled
snmalloc CI / Mac OS macos-13 Debug -DSNMALLOC_USE_CXX17=ON (push) Has been cancelled
snmalloc CI / Mac OS macos-14 Debug -DSNMALLOC_USE_CXX17=ON (push) Has been cancelled
snmalloc CI / Mac OS macos-15 Debug -DSNMALLOC_USE_CXX17=ON (push) Has been cancelled
snmalloc CI / Mac OS macos-13 Release (push) Has been cancelled
snmalloc CI / Mac OS macos-14 Release (push) Has been cancelled
snmalloc CI / Mac OS macos-15 Release (push) Has been cancelled
snmalloc CI / Mac OS macos-13 Release -DSNMALLOC_USE_CXX17=ON (push) Has been cancelled
snmalloc CI / Mac OS macos-14 Release -DSNMALLOC_USE_CXX17=ON (push) Has been cancelled
snmalloc CI / Mac OS macos-15 Release -DSNMALLOC_USE_CXX17=ON (push) Has been cancelled
snmalloc CI / FreeBSD-13.2 Debug (push) Has been cancelled
snmalloc CI / FreeBSD-13.2 Release (push) Has been cancelled
snmalloc CI / NetBSD-9.2 Release (push) Has been cancelled
snmalloc CI / Sanitizer - ubuntu-22.04 Release libc++ (TSan + UBSan) (push) Has been cancelled
snmalloc CI / Sanitizer - ubuntu-24.04 Release libc++ (TSan + UBSan) (push) Has been cancelled
snmalloc CI / Crossbuild - Debug cross-build for riscv64-linux-gnu (push) Has been cancelled
snmalloc CI / Crossbuild - Release cross-build for riscv64-linux-gnu (push) Has been cancelled
snmalloc CI / Crossbuild - Debug cross-build for aarch64-linux-gnu (push) Has been cancelled
snmalloc CI / Crossbuild - Release cross-build for aarch64-linux-gnu (push) Has been cancelled
snmalloc CI / Crossbuild - Debug cross-build for arm-linux-gnueabihf (push) Has been cancelled
snmalloc CI / Crossbuild - Release cross-build for arm-linux-gnueabihf (push) Has been cancelled
snmalloc CI / Windows - windows-2022 ARM64 Debug (push) Has been cancelled
snmalloc CI / Windows - windows-2022 ARM64 Release (push) Has been cancelled
snmalloc CI / Windows - windows-2022 ARM64EC Debug (push) Has been cancelled
snmalloc CI / Windows - windows-2022 ARM64EC Release (push) Has been cancelled
snmalloc CI / Windows - windows-2022 Win32 Debug (push) Has been cancelled
snmalloc CI / Windows - windows-2022 Win32 Debug -T ClangCL (push) Has been cancelled
snmalloc CI / Windows - windows-2025 Win32 Debug (push) Has been cancelled
snmalloc CI / Windows - windows-2025 Win32 Debug -T ClangCL (push) Has been cancelled
snmalloc CI / Windows - windows-2022 Win32 Release (push) Has been cancelled
snmalloc CI / Windows - windows-2022 Win32 Release -T ClangCL (push) Has been cancelled
snmalloc CI / Windows - windows-2025 Win32 Release (push) Has been cancelled
snmalloc CI / Windows - windows-2025 Win32 Release -T ClangCL (push) Has been cancelled
snmalloc CI / Windows - windows-2022 x64 Debug (push) Has been cancelled
snmalloc CI / Windows - windows-2022 x64 Debug -T ClangCL (push) Has been cancelled
snmalloc CI / Windows - windows-2025 x64 Debug (push) Has been cancelled
snmalloc CI / Windows - windows-2025 x64 Debug -T ClangCL (push) Has been cancelled
snmalloc CI / Windows - windows-2022 x64 Release (push) Has been cancelled
snmalloc CI / Windows - windows-2022 x64 Release -T ClangCL (push) Has been cancelled
snmalloc CI / Windows - windows-2025 x64 Release (push) Has been cancelled
snmalloc CI / Windows - windows-2025 x64 Release -T ClangCL (push) Has been cancelled
snmalloc CI / Windows - windows-2022 x64 Release Windows 8 compatible (push) Has been cancelled
snmalloc CI / Format check (push) Has been cancelled
snmalloc CI / Fuzzing (push) Has been cancelled
snmalloc CI / Self Vendored STL - macos-latest clang++ (push) Has been cancelled
snmalloc CI / Self Vendored STL - ubuntu-24.04 clang++-18 (push) Has been cancelled
snmalloc CI / Self Vendored STL - windows-2022 clang-cl (push) Has been cancelled
snmalloc CI / Self Vendored STL - ubuntu-24.04 g++-14 (push) Has been cancelled
snmalloc CI / gwp-asan (ubuntu-24.04, Debug) (push) Has been cancelled
snmalloc CI / gwp-asan (ubuntu-24.04, RelWithDebInfo) (push) Has been cancelled
snmalloc CI / gwp-asan (ubuntu-24.04-arm, Debug) (push) Has been cancelled
snmalloc CI / gwp-asan (ubuntu-24.04-arm, RelWithDebInfo) (push) Has been cancelled
snmalloc CI / all-checks (push) Has been cancelled
snmalloc CI for Morello / morello Debug Hybrid (push) Has been cancelled
snmalloc CI for Morello / morello Debug Purecap (push) Has been cancelled
snmalloc CI for Morello / morello Release Hybrid (push) Has been cancelled
snmalloc CI for Morello / morello Release Purecap (push) Has been cancelled
This commit is contained in:
@@ -509,6 +509,11 @@ if(NOT SNMALLOC_HEADER_ONLY_LIBRARY)
|
||||
function(compile name TYPE ${ARGN})
|
||||
add_library(${name} ${TYPE} ${ARGN})
|
||||
target_link_libraries(${name} PRIVATE snmalloc)
|
||||
|
||||
# PRIVATE linking still touches INTERFACE level linking for unknown reasons.
|
||||
# Check https://github.com/microsoft/snmalloc/pull/799 for details.
|
||||
set_target_properties(${name} PROPERTIES INTERFACE_LINK_LIBRARIES "")
|
||||
|
||||
target_compile_definitions(${name} PRIVATE "SNMALLOC_USE_${SNMALLOC_CLEANUP}")
|
||||
|
||||
add_warning_flags(${name})
|
||||
|
||||
Reference in New Issue
Block a user